Bug Report: # in ohb titles breaks final pack download
BotB Academy Bug Reports and Feature Requests
 
 
121079
Level 30 Chipist
post #121079 :: 2020.05.18 6:16am
  
  Xyz and xterm liēkd this
im 99% sure thats why u get a 404 if you try to download some finalpacks. i didnt check every battle but looks like every ohb with ####### in the title is affected
 
 
121103
Level 21 Playa
post #121103 :: 2020.05.18 11:00am
  
  kleeder liēkd this
there might be some other characters that break it too. i'll see if i can deduce any others.
 
 
121120
Level 20 Criticist
Xyz
post #121120 :: 2020.05.18 2:10pm
  
  noodlebuckets liēkd this
botb gets pounded
 
 
121137
Level 23 Chipist
post #121137 :: 2020.05.18 4:47pm
  
  xterm liēkd this
that's lood
 
 
121210
Level 21 Playa
post #121210 :: 2020.05.19 6:09pm
  
  kleeder liēkd this
commas also do it:

https://battleofthebits.org/arena/OHC/4333/

#commacore
 
 
121211
Level 15 Chipist
post #121211 :: 2020.05.19 6:28pm
  
  xterm liēkd this
this is why you cant use C#
get it
 
 
121347
Level 27 Chipist
post #121347 :: 2020.05.22 9:04am :: edit 2020.05.22 9:06am
  
  Robyn, tennisers, xterm, argarak, kleeder and Savestate liēkd this
The finalpack can be restored by using a %23 in the URL in place of the wrong replacement characters where the # was. For example: https://battleofthebits.org/disk/battle/00004645/OHC04645%20OHB%3735113%20-%20draw%20for%20strobe!%20finalpack.zip is a broken link, whereas https://battleofthebits.org/disk/battle/00004645/OHC04645 OHB%23113 - draw for strobe! finalpack.zip works fine.
 
 
121361
Level 21 Playa
post #121361 :: 2020.05.22 2:30pm
  
  tennisers liēkd this
hmm, so it's encoding as %3735. interestingly, the ascii value for % is 37, and for # is 35:

https://www.tutorialspoint.com/http/http_url_encoding.htm

so it looks like maybe it's putting a % in front ("%#"), then converting those special characters to ascii ("3735") [note: not the same as the % code, because that's in hex], and then adding an extra % in front ("%3735").

that's my best guess at least :U
 
 
121545
Level 28 Hostist
post #121545 :: 2020.05.25 2:16pm
  
  KungFuFurby, argarak, xterm and kleeder liēkd this
ok, think i got this figured out
copied the encoding code from entry files to finalpacks and that fixed the # issue but not the , issue
so i decided to simply load the battle from the URL data (battle_id) and forward the pack from there ignoring the filename in the URL altogether
let me know if i made any new breakage!
 
 

LOGIN or REGISTER to add your own comments!